fix(Swift): Addressing some gaps in Geo Gen2 doc pages #7573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdworld11
previously approved these changes
May 10, 2024
hdworld11
previously approved these changes
May 13, 2024
harsh62
previously approved these changes
May 13, 2024
josefaidt
reviewed
May 13, 2024
src/pages/[platform]/build-a-backend/add-aws-services/geo/set-up-geo/index.mdx
Outdated
Show resolved
Hide resolved
josefaidt
reviewed
May 13, 2024
Comment on lines
+341
to
+345
| Make sure to generate the `amplify_outputs.json` file by running the following command: | ||
|
|
||
| ```bash title="Terminal" showLineNumbers={false} | ||
| npx ampx sandbox | ||
| ``` |
There was a problem hiding this comment.
should this be moved outside the swift block? I think we should keep the prose relatively the same across platforms (with a few exceptions) for maintainability and a concise UX
There was a problem hiding this comment.
We could explore doing that in the future as a docs clean up, but right now each platform is doing its own thing
There was a problem hiding this comment.
platform-specific callouts were (mostly) cleaned up when content was ported into this new structure. swift has the callout to move the file into the project, which is fine, but prose should be relatively the same
…up-geo/index.mdx Co-authored-by: josef <josef.aidt@gmail.com>
hdworld11
approved these changes
May 13, 2024
harsh62
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR addresses the following issues within the Swift Gen2 documentation for Geo:
Set up Amplify Geo
amplify_outputs.jsonfile to the project.Work with maps
Configure location search
aws_regionto the backend code snippet.Work with location search
Related GitHub issue #, if available:
Instructions
If this PR should not be merged upon approval for any reason, please submit as a DRAFT
Which product(s) are affected by this PR (if applicable)?
Which platform(s) are affected by this PR (if applicable)?
Please add the product(s)/platform(s) affected to the PR title
Checks
Does this PR conform to the styleguide?
Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.
Are any files being deleted with this PR? If so, have the needed redirects been created?
Are all links in MDX files using the MDX link syntax rather than HTML link syntax?
ref: MDX:
[link](https://docs.amplify.aws/)HTML:
<a href="https://docs.amplify.aws/">link</a>When this PR is ready to merge, please check the box below
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.