fix(logging): set-up code snippets with backend.ts #7569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawmicha
requested review from
ykethan,
Jay2113,
chrisbonifacio,
aspittel,
renebrandel,
swaminator,
dbanksdesign,
josefaidt,
ErikCH,
arundna,
hdworld11 and
a team
as code owners
lawmicha
force-pushed
the
fix.logging.set-up
branch
from
e2c404d
to
3cacee4
Compare
phantumcode
reviewed
May 10, 2024
src/pages/[platform]/build-a-backend/add-aws-services/logging/set-up-logging/index.mdx
Outdated
Show resolved
Hide resolved
phantumcode
previously approved these changes
May 10, 2024
josefaidt
reviewed
May 13, 2024
src/pages/[platform]/build-a-backend/add-aws-services/logging/set-up-logging/index.mdx
Outdated
Show resolved
Hide resolved
josefaidt
reviewed
May 13, 2024
src/pages/[platform]/build-a-backend/add-aws-services/logging/set-up-logging/index.mdx
Outdated
Show resolved
Hide resolved
josefaidt
approved these changes
May 21, 2024
phantumcode
approved these changes
May 22, 2024
reesscot
approved these changes
May 23, 2024
ykethan
reviewed
May 23, 2024
Comment on lines
+151
to
+153
| Then, update `backend.ts` and replace the `<log-group-name>` with your own value. | ||
|
|
||
| `<log-group-name>` is the log group that logs will be sent to. |
There was a problem hiding this comment.
Then, update `backend.ts` and replace the `<log-group-name>` with your own value.
`<log-group-name>` is the log group that logs will be sent to.
feel like we can make this a single line
ykethan
reviewed
May 23, 2024
| // highlight-end | ||
| ``` | ||
|
|
||
| The `<log-group-name>` and region will be printed out in the terminal. You can use this information to setup the Amplify library in the next section. |
There was a problem hiding this comment.
maybe i missed this but what prints the log group to the terminal?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Update the logging construct with example integration with the existing auth backend.
Related GitHub issue #, if available:
Instructions
If this PR should not be merged upon approval for any reason, please submit as a DRAFT
Which product(s) are affected by this PR (if applicable)?
Which platform(s) are affected by this PR (if applicable)?
Please add the product(s)/platform(s) affected to the PR title
Checks
Does this PR conform to the styleguide?
Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.
Are any files being deleted with this PR? If so, have the needed redirects been created?
Are all links in MDX files using the MDX link syntax rather than HTML link syntax?
ref: MDX:
[link](https://docs.amplify.aws/)HTML:
<a href="https://docs.amplify.aws/">link</a>When this PR is ready to merge, please check the box below
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.