Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes focus state and text selection issue #7529

Closed
wants to merge 1 commit into from

Conversation

renebrandel
Copy link
Contributor

@renebrandel renebrandel commented May 7, 2024

Description of changes:

  • Fixes the focus state clarity issue:
image image - User can't select the word "copy" anymore image

Related GitHub issue #, if available:

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@renebrandel renebrandel requested a review from a team as a code owner May 7, 2024 17:48
}

.highlight-copy-block-hint {
position: absolute;
top: 0;
right: 1.8rem;
color: white;
user-select: none;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I test this locally, it still copies "highlighted code example" since that text exists outside of this class. You can test by using your mouse to drag and copy/paste text.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to select it (posted a screenshot of that on the PR overview). Can you screenshot your case, maybe I'm misinterpreting the issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm testing on this page locally with the code block in this section: http://localhost:3000/react/build-a-backend/add-aws-services/deletion-backup-resources/#enabling-point-in-time-recovery-for-dynamodb-tables

Drag your mouse to select the whole code block, then use ctrl + c or right click to copy and paste the content somewhere. At the end of what I paste, I see the text "highlighted code example" because that text exists outside of the class you added user-select: none to:

Screenshot 2024-05-07 at 2 36 05 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants