Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(swift): update gen 2 getting started guide #7460

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

atierian
Copy link
Member

@atierian atierian commented May 2, 2024

Description of changes:

  • Adds highlights in code snippets for changes.
  • Adds some missing import statements
  • Misc. minor code changes
  • Replaces image to include all necessary targets.

Related GitHub issue #, if available:

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • ~Are all links in MDX files using the MDX link syntax rather than HTML link syntax?
    ~
    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

josefaidt
josefaidt previously approved these changes May 2, 2024
lawmicha
lawmicha previously approved these changes May 3, 2024
@reesscot reesscot changed the base branch from next-release/main to main May 3, 2024 23:08
@reesscot reesscot dismissed stale reviews from lawmicha and josefaidt May 3, 2024 23:08

The base branch was changed.

@reesscot
Copy link
Contributor

reesscot commented May 3, 2024

@atierian I updated this to point to main and updated with latest link fixes from main to allow CI to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants