Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mv mobile auth sign-in content to "connect your frontend" #7456

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

josefaidt
Copy link
Contributor

Description of changes:

Related GitHub issue #, if available:

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@josefaidt josefaidt requested a review from a team as a code owner May 2, 2024 18:34
@reesscot
Copy link
Contributor

reesscot commented May 3, 2024

@josefaidt Please update this pr to point to main and merge main in for redirect fixes

@josefaidt josefaidt changed the base branch from next-release/main to main May 5, 2024 18:41
@github-actions github-actions bot added the redirects-needed Redirects need to be created for deleted pages label May 6, 2024
@josefaidt josefaidt enabled auto-merge (squash) May 6, 2024 19:22
Copy link

mergify bot commented May 6, 2024

@josefaidt, since a file was deleted from the src/pages and/or src/fragments directories, redirects might need to be set up so these previous pages do not 404. If redirects are needed, please answer these questions for each redirect that is needed:

  • What is the source address of the redirect? (Where are you trying to redirect from?)

  • What is the target address of the redirect? (Where are you trying to redirect to?)

  • Type of redirect? 301 - permanent redirect or 302 - temporary redirect? (More info on Amplify Hosting redirects here: https://docs.aws.amazon.com/amplify/latest/userguide/redirects.html)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redirects-needed Redirects need to be created for deleted pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants