[Amplify JS Admin Actions] Correctly passing Auth header and query string parameters #7234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
josefaidt
previously approved these changes
Apr 17, 2024
muvashi
requested review from
ykethan,
Jay2113,
chrisbonifacio,
aspittel,
renebrandel,
swaminator,
dbanksdesign,
ErikCH,
arundna and
hdworld11
as code owners
|
@muvashi Can you please rebase this PR against the latest version of |
auto-merge was automatically disabled
May 10, 2024 18:53
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
May 10, 2024 18:53
Pull request was closed
|
This PR is updated. Requesting team to please review and merge. |
josefaidt
approved these changes
May 11, 2024
reesscot
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Two changes are done in this PR.
Previous :- Authorization:
${(await fetchAuthSession()).tokens.accessToken.payload}This is not working as expected and giving CORS error in the browser.
Updated to :- Authorization:
${(await fetchAuthSession()).tokens.accessToken}Working fine.
Previous :- queryStringParameters
It is not giving any error but parameters are neither visible in the request URL nor in the Lambda function.
updated to :- queryParams
Working as expected.
Related GitHub issue #, if available: NA
Instructions
If this PR should not be merged upon approval for any reason, please submit as a DRAFT
Which product(s) are affected by this PR (if applicable)?
Which platform(s) are affected by this PR (if applicable)?
Please add the product(s)/platform(s) affected to the PR title
Checks
[Y ] Does this PR conform to the styleguide?
[ N] Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.
[N ] Are any files being deleted with this PR? If so, have the needed redirects been created?
[ Y] Are all links in MDX files using the MDX link syntax rather than HTML link syntax?
ref: MDX:
[link](https://docs.amplify.aws/)HTML:
<a href="https://docs.amplify.aws/">link</a>When this PR is ready to merge, please check the box below
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.