refactor(authenticator)!: use Amplify JS auto sign in #2642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
August 4, 2022 10:19
🦋 Changeset detectedLatest commit: b458299 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ErikCH
changed the title
added 2 commits
September 24, 2022 15:54
wlee221
previously approved these changes
Oct 31, 2022
wlee221
approved these changes
Oct 31, 2022
|
Tiny little nit before we merge -- let's rename the title / commit to follow conventional commits (e.g. |
ErikCH
changed the title
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto Sign In
The will update the Authenticator and xState machine to use the auto sign in feature of the Amplify JS library. This will be the first PR in the Email Link Verification changes.
Description of changes
Added in new breaking change based on the Email Link Verification API Breaking change document.Added a new breaking change that will require a newer version of the Amplify JS library. In addition, a new breaking change was added for users who override
handleSignUp. They will need to addautoSignIntoenabled.This change will accomplish the following
autoSignfeature enabled totrue.autoSignInandautoSignIn_failureare added as new hub event listenersautoSignIntoenabledaws-amplifyhas been set to ^4.3.29 for React, Vue and AngularAfter this is merged another PR will be pushed up with the Email Link Verification changes, that are non breaking.
Issue #, if available
Asana
Description of how you validated changes
Added additional E2E and unit tests
Checklist
yarn testpassessideEffectsfield updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.