Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: removing resolution since upstream has fixed the issue #1422

Merged
merged 4 commits into from Feb 26, 2022
Merged

chore: removing resolution since upstream has fixed the issue #1422

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
430dd7c
chore: removing resolution since upstream has fixed the issue
zchenwei Feb 25, 2022
a274cec
Merge branch 'main' into chenwz-remove-resolution
zchenwei Feb 25, 2022
aac0bf0
chore: removing that in canary package
zchenwei Feb 25, 2022
a7ac155
Merge branch 'main' into chenwz-remove-resolution
zchenwei Feb 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions canary/react/next/package.json
View file
Open in desktop
Expand Up @@ -14,9 +14,6 @@
"react": "17.0.2",
"react-dom": "17.0.2"
},
"resolutions": {
"eslint-plugin-react": "7.28.0"
},
"devDependencies": {
"eslint": "8.8.0",
"eslint-config-next": "12.0.10"
Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -59,7 +59,6 @@
"node-forge": "1.0.0",
"prismjs": "^1.25.0",
"prism-react-renderer": "1.2.1",
"eslint-plugin-react": "7.28.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one more in

amplify-ui/canary/react/next/package.json

Lines 17 to 19 in 625efeb

"resolutions": {
"eslint-plugin-react": "7.28.0"
},
, can you remove that as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, just realized canary package is not part of the mono repo in terms of workspaces

"trim": "^0.0.3",
"ts-jest": "^26.5.6",
"vscode-vue-languageservice": "0.27.26",
Expand Down