feat(Auth): provide AuthConfiguration from plugin #3566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3566 +/- ##
==========================================
- Coverage 68.42% 68.41% -0.01%
==========================================
Files 1077 1079 +2
Lines 36287 36359 +72
==========================================
+ Hits 24829 24875 +46
- Misses 11458 11484 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lawmicha
force-pushed
the
feat.authconfig
branch
from
44ad12b
to
e57fc72
Compare
ruisebas
reviewed
Mar 13, 2024
...h/Sources/AWSCognitoAuthPlugin/StateMachine/CodeGen/Data/IdentityPoolConfigurationData.swift
Show resolved
Hide resolved
...Auth/Sources/AWSCognitoAuthPlugin/StateMachine/CodeGen/Data/PasswordProtectionSettings.swift
Outdated
Show resolved
Hide resolved
6 tasks
harsh62
reviewed
Mar 18, 2024
| @@ -25,7 +26,7 @@ extension IdentityPoolConfigurationData: CustomDebugDictionaryConvertible { | |||
| } | |||
|
|
|||
| extension IdentityPoolConfigurationData: CustomDebugStringConvertible { | |||
| var debugDescription: String { | |||
| public var debugDescription: String { | |||
There was a problem hiding this comment.
Missing @spi
Suggested change
| public var debugDescription: String { | |
| @_spi(InternalAmplifyConfiguration) | |
| public var debugDescription: String { |
|
It would be nice if we can write some tests around the parsing logic, just to make sure everything works as intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description
AWSCognitoAuthPlugin currently provides the
amplifyconfiguration.jsonfile through thejsonConfigurationproperty. This PR deprecates that and provides the SPI public AuthConfiguration type. By only deprecating it and not removing thejsonConfigurationobject provides a non-breaking change to Authenticator that uses it.Related aws-amplify/amplify-ui-swift-authenticator#58
General Checklist
Given When Theninline code documentation and are named accordinglytestThing_condition_expectation()By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.