Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add support for GraphQL filter attributeExists #3484

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

5d
Copy link
Member

@5d 5d commented Jan 26, 2024

Issue #

Description

  • add support for AppSync GraphQL filter attributeExists
  • fix query filter with nil value.
  • optimize the SQL query generation for attributeExists and eq(nil)/ne(nil)

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest January 26, 2024 20:50 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 11, 2024 23:18 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 11, 2024 23:18 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 11, 2024 23:18 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 11, 2024 23:18 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 11, 2024 23:18 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 11, 2024 23:18 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 11, 2024 23:18 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 11, 2024 23:18 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 11, 2024 23:18 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 11, 2024 23:18 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 11, 2024 23:18 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 11, 2024 23:18 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 11, 2024 23:18 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 11, 2024 23:18 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 11, 2024 23:18 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest March 11, 2024 23:18 — with GitHub Actions Inactive
@5d 5d force-pushed the 5d/graphql-filter-support branch from ba2976b to 5d7c180 Compare April 12, 2024 22:54
@5d 5d changed the title feat(datastore): add support for GraphQL filter attributeExists feat(api): add support for GraphQL filter attributeExists Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants