Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] feat(api): Add AWSAPIPluginConfiguration for explicit config #3426

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lawmicha
Copy link
Member

Issue #

Description

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lawmicha lawmicha changed the title feat(api): Add AWSAPIPluginConfiguration for explicit config [DRAFT] feat(api): Add AWSAPIPluginConfiguration for explicit config Dec 18, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (f9b02de) 67.89% compared to head (90a37a7) 67.85%.
Report is 3 commits behind head on main.

Files Patch % Lines
...s/API/Sources/AWSAPIPlugin/Configuration/API.swift 0.00% 19 Missing ⚠️
...PICategoryPluginConfiguration+EndpointConfig.swift 60.00% 8 Missing ⚠️
...ugin/Configuration/AWSAPIPluginConfiguration.swift 25.00% 6 Missing ⚠️
...I/ClientBehavior/APICategory+GraphQLBehavior.swift 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3426      +/-   ##
==========================================
- Coverage   67.89%   67.85%   -0.05%     
==========================================
  Files        1079     1081       +2     
  Lines       36359    36444      +85     
==========================================
+ Hits        24687    24729      +42     
- Misses      11672    11715      +43     
Flag Coverage Δ
API_plugin_unit_test 66.86% <65.62%> (-0.22%) ⬇️
AWSPluginsCore 64.13% <ø> (ø)
Amplify 48.08% <0.00%> (-0.03%) ⬇️
Analytics_plugin_unit_test 81.16% <ø> (ø)
Auth_plugin_unit_test 78.90% <ø> (-0.10%) ⬇️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 80.44% <ø> (+0.04%) ⬆️
Geo_plugin_unit_test 70.75% <ø> (ø)
Logging_plugin_unit_test 63.34% <ø> (ø)
Predictions_plugin_unit_test 37.16% <ø> (ø)
PushNotifications_plugin_unit_test 87.13% <ø> (ø)
Storage_plugin_unit_test 77.51% <ø> (ø)
unit_tests 67.85% <63.63%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants