Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(datastore): fix observe query integration test #3033

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

5d
Copy link
Member

@5d 5d commented Jun 22, 2023

Issue #

Description

  • stablize integration test cases of observe query
    • unsubscribe to datastore publisher when test case is finished
    • use new fulfillment async API

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@5d 5d requested a review from a team as a code owner June 22, 2023 01:39
@5d 5d temporarily deployed to IntegrationTest June 22, 2023 17:13 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 22, 2023 17:15 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 22, 2023 17:15 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 22, 2023 17:15 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 22, 2023 17:15 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 22, 2023 17:15 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 22, 2023 17:15 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 22, 2023 18:13 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 22, 2023 18:13 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 22, 2023 18:13 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 22, 2023 18:13 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 22, 2023 18:13 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 22, 2023 18:13 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 22, 2023 18:13 — with GitHub Actions Inactive
@5d 5d temporarily deployed to IntegrationTest June 22, 2023 18:13 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants