Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] feat(datastore): Add ConnectivityMonitor to RemoteSyncEngine #2758

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lawmicha
Copy link
Member

@lawmicha lawmicha commented Feb 8, 2023

Issue #

Description

This PR starts will pulling in the ConnectivityMonitor, see aws-amplify/aws-appsync-realtime-client-ios#58 for a reference implementation. The code copied over is owned by the DataStore plugin and used internally by the RemoteSyncEngine. There is also another NetworkMonitor usage in analytics here https://github.com/aws-amplify/amplify-swift/blob/main/AmplifyPlugins/Analytics/Sources/AWSPinpointAnalyticsPlugin/Support/Utils/NetworkMonitor.swift for reference.

The initial commit only adds the classes and instantiates a connectivity monitor, and does not build much logic around it.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lawmicha lawmicha added the datastore Issues related to the DataStore category label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datastore Issues related to the DataStore category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant