Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add configuration builder implementation #1732

Draft
wants to merge 2 commits into
base: v1
Choose a base branch
from

Conversation

atierian
Copy link
Member

@atierian atierian commented Apr 7, 2022

Issue #, if available:

Description of changes:

Check points: (check or cross out if not relevant)

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

Merging #1732 (3be32e9) into main (70209ed) will increase coverage by 1.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1732      +/-   ##
==========================================
+ Coverage   59.08%   60.65%   +1.56%     
==========================================
  Files         716      307     -409     
  Lines       21874    13482    -8392     
==========================================
- Hits        12924     8177    -4747     
+ Misses       8950     5305    -3645     
Flag Coverage Δ
API_plugin_unit_test 62.51% <ø> (ø)
AWSPluginsCore 71.30% <ø> (ø)
Amplify ?
Analytics_plugin_unit_test ?
Auth_plugin_unit_test ?
DataStore_plugin_unit_test 75.39% <ø> (-0.08%) ⬇️
Geo_plugin_unit_test 52.12% <ø> (ø)
Predictions_plugin_unit_test 25.01% <ø> (-1.80%) ⬇️
Storage_plugin_unit_test 58.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...oreCategoryPlugin/Sync/Support/Model+Compare.swift 69.79% <0.00%> (-2.09%) ⬇️
...gin/Subscribe/DataStoreObserveQueryOperation.swift 74.64% <0.00%> (-0.94%) ⬇️
...edictions/Result/IdentifyEntityMatchesResult.swift
...ies/DataStore/Subscribe/MutationEvent+Schema.swift
...lugin/Operation/CoreMLInterpretTextOperation.swift
...Plugin/Operation/CoreMLSpeechToTextOperation.swift
...Auth/Request/AuthConfirmUserAttributeRequest.swift
...t/AmplifyInProcessReportingOperation+Combine.swift
...uthorizationProviderAdapter+SignedOutSession.swift
Amplify/Categories/Storage/StorageCategory.swift
... and 401 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@royjit royjit changed the base branch from main to v1 October 17, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants