Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ops): pin babel-core and babel-cli version #9593

Merged
merged 1 commit into from Feb 15, 2022

Conversation

jamesaucode
Copy link
Contributor

Description of changes

yarn build was failing due to an issue in bable. Pinning the @babel/core and @babel/cli version.
See: babel/babel#14273

Issue #, if available

N/A

Description of how you validated changes

ran yarn setup-dev from a fresh clone.

Checklist

  • PR description included
  • yarn test passes
  • [ ]
    By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jamesaucode jamesaucode changed the title pin babel-core and babel-cli version fix(ops): pin babel-core and babel-cli version Feb 15, 2022
Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @jamesaucode 🌮

Copy link
Contributor

@sammartinez sammartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this James!

Copy link
Contributor

@sammartinez sammartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

Copy link
Member

@david-mcafee david-mcafee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jamesaucode jamesaucode merged commit a0fc830 into aws-amplify:main Feb 15, 2022
@jamesaucode jamesaucode deleted the pin-babel-version branch February 15, 2022 22:37
@JLHwung
Copy link

JLHwung commented Feb 15, 2022

The upstream Babel issue has been fixed in 7.17.4.

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants