-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: babel core failing create-react-app #9548
Conversation
Codecov Report
@@ Coverage Diff @@
## main #9548 +/- ##
=======================================
Coverage 78.29% 78.29%
=======================================
Files 250 250
Lines 18258 18258
Branches 3927 3927
=======================================
Hits 14296 14296
Misses 3832 3832
Partials 130 130 Continue to review full report at Codecov.
|
Fix for CRA based on microsoft/fluentui#21545 |
This reverts commit d3e16c7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closing this PR since testing this showed it wouldn't work and also the core issue has been fixed by babel |
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Description of changes
Fix babel/core issue here - aws-amplify/amplify-ui#1242
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.