Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: babel core failing create-react-app #9548

Closed
wants to merge 4 commits into from
Closed

Conversation

ashika01
Copy link
Contributor

@ashika01 ashika01 commented Feb 3, 2022

Description of changes

Fix babel/core issue here - aws-amplify/amplify-ui#1242

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashika01 ashika01 changed the title Fix/babel core Fix: babel core failing create-react-app Feb 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2022

Codecov Report

Merging #9548 (690ca2b) into main (bb60060) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9548   +/-   ##
=======================================
  Coverage   78.29%   78.29%           
=======================================
  Files         250      250           
  Lines       18258    18258           
  Branches     3927     3927           
=======================================
  Hits        14296    14296           
  Misses       3832     3832           
  Partials      130      130           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb60060...690ca2b. Read the comment docs.

@ashika01
Copy link
Contributor Author

ashika01 commented Feb 3, 2022

Fix for CRA based on microsoft/fluentui#21545

.circleci/config.yml Outdated Show resolved Hide resolved
@iartemiev iartemiev changed the title Fix: babel core failing create-react-app fix: babel core failing create-react-app Feb 3, 2022
Copy link
Contributor

@iartemiev iartemiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashika01
Copy link
Contributor Author

ashika01 commented Feb 3, 2022

Closing this PR since testing this showed it wouldn't work and also the core issue has been fixed by babel

@ashika01 ashika01 closed this Feb 3, 2022
@ashika01 ashika01 deleted the fix/babel-core branch February 3, 2022 17:17
@github-actions
Copy link

github-actions bot commented Feb 5, 2023

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants