chore: Remove UI packages #9322
Conversation
|
This pull request fixes 78 alerts when merging 8d73f5f into c1e0fd8 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 78 alerts when merging 833b2eb into c1e0fd8 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 78 alerts when merging 923acaf into c1e0fd8 - view on LGTM.com fixed alerts:
|
Codecov Report
@@ Coverage Diff @@
## main #9322 +/- ##
==========================================
- Coverage 78.01% 77.71% -0.31%
==========================================
Files 250 172 -78
Lines 18108 14626 -3482
Branches 3882 3061 -821
==========================================
- Hits 14127 11366 -2761
+ Misses 3851 3174 -677
+ Partials 130 86 -44
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
We should have a convo on this one @ericclemmons as this will be a breaking change and will require a major version bump which we will not being doing until next year sometime
|
@sammartinez Got it! Let's coordinate with @Milan-Shah on our short-term needs and find an alternate solution. |
| @@ -25,63 +25,6 @@ describe('aws-amplify', () => { | |||
| "PubSub", | |||
| "Cache", | |||
| "Interactions", | |||
| "a", | |||
There was a problem hiding this comment.
These snapshots were the generated CSS classnames:
a: 'Anchor__a___1_Iz8',
button: 'Button__button___vS7Mv',
signInButton: 'Button__signInButton___3bUH-',
googleSignInButton: 'Button__googleSignInButton___1YiCu',
signInButtonIcon: 'Button__signInButtonIcon___ihN75',
auth0SignInButton: 'Button__auth0SignInButton___znnCj',
facebookSignInButton: 'Button__facebookSignInButton___34Txh',
amazonSignInButton: 'Button__amazonSignInButton___2EMtl',
oAuthSignInButton: 'Button__oAuthSignInButton___3UGOl',
signInButtonContent: 'Button__signInButtonContent___xqTXJ',
formContainer: 'Form__formContainer___1GA3x',
formSection: 'Form__formSection___1PPvW',
formField: 'Form__formField___38Ikl',
formRow: 'Form__formRow___2mwRs',
hint: 'Hint__hint___2XngB',
input: 'Input__input___3e_bf',
inputLabel: 'Input__inputLabel___3VF0S',
label: 'Input__label___23sO8',
radio: 'Input__radio___2hllK',
navBar: 'Nav__navBar___xtCFA',
navRight: 'Nav__navRight___1QG2J',
nav: 'Nav__nav___2Dx2Y',
navItem: 'Nav__navItem___1LtFQ',
photoPickerButton: 'PhotoPicker__photoPickerButton___2XdVn',
photoPlaceholder: 'PhotoPicker__photoPlaceholder___2JXO4',
photoPlaceholderIcon: 'PhotoPicker__photoPlaceholderIcon___3Et71',
container: 'Section__container___3YYTG',
actionRow: 'Section__actionRow___2LWSU',
sectionHeader: 'Section__sectionHeader___2djyg',
sectionHeaderHint: 'Section__sectionHeaderHint___3Wxdc',
sectionBody: 'Section__sectionBody___ihqqd',
sectionHeaderContent: 'Section__sectionHeaderContent___1UCqa',
sectionFooter: 'Section__sectionFooter___1T54C',
sectionFooterPrimaryContent: 'Section__sectionFooterPrimaryContent___2r9ZX',
sectionFooterSecondaryContent: 'Section__sectionFooterSecondaryContent___Nj41Q',
selectInput: 'SelectInput__selectInput___3efO4',
strike: 'Strike__strike___1XV1b',
strikeContent: 'Strike__strikeContent___10gLb',
toast: 'Toast__toast___XXr3v',
toastClose: 'Toast__toastClose___18lU4',
totpQrcode: 'Totp__totpQrcode___1crLx',
sumerianSceneContainer: 'XR__sumerianSceneContainer___3nVMt',
sumerianScene: 'XR__sumerianScene___2Tt7-',
loadingOverlay: 'XR__loadingOverlay___IbqcI',
loadingContainer: 'XR__loadingContainer___2Itxb',
loadingLogo: 'XR__loadingLogo___Ub7xQ',
loadingSceneName: 'XR__loadingSceneName___3__ne',
loadingBar: 'XR__loadingBar___2vcke',
loadingBarFill: 'XR__loadingBarFill___3M-D9',
sceneErrorText: 'XR__sceneErrorText___2y0tp',
sceneBar: 'XR__sceneBar___2ShrP',
sceneName: 'XR__sceneName___1ApHr',
sceneActions: 'XR__sceneActions___7plGs',
actionButton: 'XR__actionButton___2poIM',
tooltip: 'XR__tooltip___UYyhn',
actionIcon: 'XR__actionIcon___2qnd2',
autoShowTooltip: 'XR__autoShowTooltip___V1QH7',
|
There are some new commits since we migrated to aws-amplify/amplify-ui:
Should we do one final migration from JS repo with help from @ErikCH before we merge this PR? |
|
@wlee221 Because of the current (and potential future drift), it may be best to update https://github.com/aws-amplify/amplify-ui/tree/legacy/legacy after merge. Otherwise we may end up repeating this process repeatedly. |
|
As we have discussed, I am going to close this PR out for now until we move to a breaking change for removal of the UI packages. |
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Description of changes
This PR removes UI-packages (**with the exception of
aws-amplify-react-native) and directs customers to https://github.com/aws-amplify/amplify-ui/tree/legacy/legacy.With the creation of https://github.com/aws-amplify/amplify-ui and launch of https://ui.docs.amplify.aws/, Amplify UI is a 1st-class citizen with a dedicate team.
So the ongoing maintenance (and most importantly, release) of UI packages will be managed by the @aws-amplify/amplify-ui team.
This PR keeps a
README.mdin each folder for any customers or developers who aren't aware of the UI efforts, similar to:Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.