Handle additional error case #604
Conversation
Gracefully handle case where fetch raises an exception with response undefined.
Codecov Report
@@ Coverage Diff @@
## master #604 +/- ##
=======================================
Coverage 89.27% 89.27%
=======================================
Files 69 69
Lines 3217 3217
Branches 611 611
=======================================
Hits 2872 2872
Misses 328 328
Partials 17 17Continue to review full report at Codecov.
|
| @@ -56,6 +56,13 @@ export default class Client { | |||
| return callback(error); | |||
| }) | |||
| .catch(() => { | |||
| if (!response) { | |||
| return callback({ | |||
| code: 418, | |||
There was a problem hiding this comment.
No, it is not appropriate. Suggestions?
There was a problem hiding this comment.
lol nice! 🍵 Perhaps just a simple 400 works?
nidsharm
added
needs-feedback
|
@charlesbullis thanks for your PR, this issue was solve with PR #706 Thanks again! |
ghost
removed
the
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Gracefully handle case where fetch raises an exception with response undefined.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.