Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@aws-amplify/analytics): change logger.error back to debug #5722

Merged
merged 1 commit into from May 8, 2020

Conversation

iartemiev
Copy link
Contributor

fix regression #5618 (comment)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@iartemiev iartemiev requested a review from sammartinez May 8, 2020 13:08
@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #5722 into master will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5722   +/-   ##
=======================================
  Coverage   73.60%   73.60%           
=======================================
  Files         204      204           
  Lines       11881    11881           
  Branches     2239     2325   +86     
=======================================
  Hits         8745     8745           
+ Misses       2974     2954   -20     
- Partials      162      182   +20     
Impacted Files Coverage Δ
packages/analytics/src/Providers/EventBuffer.ts 30.55% <0.00%> (ø)
...ges/analytics/src/Providers/AWSPinpointProvider.ts 75.53% <100.00%> (ø)
packages/auth/src/OAuth/OAuth.ts 48.12% <0.00%> (ø)
packages/core/src/Credentials.ts 31.48% <0.00%> (ø)
packages/analytics/src/Analytics.ts 64.81% <0.00%> (ø)
packages/datastore/src/sync/outbox.ts 25.00% <0.00%> (ø)
packages/datastore/src/storage/storage.ts 67.59% <0.00%> (ø)
packages/core/src/OAuthHelper/GoogleOAuth.ts 32.65% <0.00%> (ø)
packages/core/src/Util/Reachability.native.ts 37.50% <0.00%> (ø)
packages/xr/src/Providers/SumerianProvider.ts 47.55% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acc48cd...2a73d31. Read the comment docs.

Copy link
Contributor

@ashika01 ashika01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@iartemiev iartemiev closed this May 8, 2020
@iartemiev iartemiev reopened this May 8, 2020
@iartemiev iartemiev merged commit 160244b into aws-amplify:master May 8, 2020
@iartemiev iartemiev deleted the issue5423 branch May 8, 2020 20:57
amhinson pushed a commit to amhinson/amplify-js that referenced this pull request May 11, 2020
amhinson pushed a commit to amhinson/amplify-js that referenced this pull request May 11, 2020
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants