Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert aws-amplify-vue to TypeScript #4143

Closed
wants to merge 1 commit into from
Closed

Convert aws-amplify-vue to TypeScript #4143

wants to merge 1 commit into from

Conversation

netroy
Copy link
Contributor

@netroy netroy commented Oct 7, 2019

Issue #, if available:
#1004
#3499

Description of changes:
Converts the code base for aws-amplify-vue from JavaScript to TypeScript.
This cannot generate the declaration files yet, because of this issue in vue-cli.

I'd highly recommend switching over from vue-cli-service to plain old webpack.
That might also reduce the bundle size, since vue-cli-service adds a bunch of unnecessary stuff to the built files.

Also, all vue-cli packages have been prevented from being hoisted because of this issue in vue-cli

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lgtm-com
Copy link

lgtm-com bot commented Oct 7, 2019

This pull request fixes 1 alert when merging 53c4a97 into 9a1055a - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Oct 7, 2019

This pull request fixes 1 alert when merging 083a08a into 9a1055a - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Oct 7, 2019

This pull request fixes 1 alert when merging a6a19d7 into 9a1055a - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Oct 8, 2019

This pull request fixes 1 alert when merging e835152 into 9a1055a - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@netroy
Copy link
Contributor Author

netroy commented Oct 8, 2019

not sure why the unit tests timeout?
I ran the tests on my fork, and they seem to pass just fine.
Can someone please suggest a way to debug this?

@lgtm-com
Copy link

lgtm-com bot commented Oct 8, 2019

This pull request fixes 1 alert when merging 1db52c6 into 9a1055a - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@netroy netroy closed this Oct 8, 2019
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant