Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update macos version to latest #13350

Merged
merged 9 commits into from May 14, 2024
Merged

Conversation

Samaritan1011001
Copy link
Contributor

DO NOT MERGE, prereq: https://github.com/aws-amplify/amplify-js-samples-staging/pull/859

Description of changes

Reverts the macos version to latest. This needs to be merged after the staging repo PR so the detox upgrade is in.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Samaritan1011001 Samaritan1011001 requested a review from a team as a code owner May 9, 2024 00:56
Copy link
Contributor

@jimblanc jimblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will approve once testing change reverted

@Samaritan1011001 Samaritan1011001 merged commit 09b14ed into main May 14, 2024
31 checks passed
@Samaritan1011001 Samaritan1011001 deleted the manoj-update-detox-version branch May 14, 2024 23:06
HuiSF pushed a commit that referenced this pull request May 16, 2024
* chore: pin to use macos 12 in gh actions

* test actions

* chore: use macos latest and iphone 15

* chore: revert custom branch name

* chore: revert integ test changes

---------

Co-authored-by: Ashwin Kumar <ashwsrir@amazon.com>
jimblanc pushed a commit that referenced this pull request May 16, 2024
chore: update macos version to latest (#13350)

* chore: pin to use macos 12 in gh actions

* test actions

* chore: use macos latest and iphone 15

* chore: revert custom branch name

* chore: revert integ test changes

---------

Co-authored-by: ManojNB <manojnb@amazon.com>
Co-authored-by: Ashwin Kumar <ashwsrir@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants