Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gh-actions): gen2 e2e rest api #13293

Merged
merged 5 commits into from May 2, 2024
Merged

feat(gh-actions): gen2 e2e rest api #13293

merged 5 commits into from May 2, 2024

Conversation

Samaritan1011001
Copy link
Contributor

@Samaritan1011001 Samaritan1011001 commented Apr 25, 2024

Description of changes

Updates GH actions to take in additional backend parameter and call the sample staging app with it.
Subsequent tests that need to be added for Gen2 only needs to add a new test case with the value backend: gen2 similar to what's shown here.

Issue #, if available

Description of how you validated changes

Passing GH actions on this branch.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Samaritan1011001 Samaritan1011001 requested a review from a team as a code owner April 25, 2024 21:54
@Samaritan1011001 Samaritan1011001 changed the title feat(github-actions): gen2 e2e rest api feat(gh-actions): gen2 e2e rest api Apr 29, 2024
@Samaritan1011001 Samaritan1011001 changed the base branch from gen2-storage to main April 29, 2024 21:03
@Samaritan1011001 Samaritan1011001 force-pushed the feat/rest-gen2 branch 2 times, most recently from ddf2f1e to 701d428 Compare April 29, 2024 21:04
Copy link
Contributor

@jimblanc jimblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending Israel's suggestion & removal of the pre-id branch

.github/workflows/push-integ-test.yml Outdated Show resolved Hide resolved
@Samaritan1011001 Samaritan1011001 merged commit 78a21b8 into main May 2, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants