Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: todo items remove class extension constructor overrides #13178

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HuiSF
Copy link
Contributor

@HuiSF HuiSF commented Mar 26, 2024

Description of changes

Remove the constructor overrides since we have migrated the ts target to ES2020.

Issue #, if available

Description of how you validated changes

  • Unit tests
  • Smoke tests in browser with sample app checking instanceof results

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HuiSF HuiSF marked this pull request as ready for review March 26, 2024 00:41
@HuiSF HuiSF requested review from a team as code owners March 26, 2024 00:41
@HuiSF HuiSF force-pushed the hui/chore/remove-todo-items branch from 252fc6e to ddbc027 Compare March 26, 2024 18:45
@HuiSF HuiSF force-pushed the hui/chore/remove-todo-items branch from ddbc027 to 1352926 Compare March 28, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant