-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(data): update datastore-storage-adapter subpaths #12801 #13083
Open
david-mcafee
wants to merge
9
commits into
main
Choose a base branch
from
ds-storage-adapter-subpath
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f871d71
fix(data): update datastore-storage-adapter subpaths
david-mcafee 389cb1d
run against E2E tests
david-mcafee 01bfd83
empty commit
david-mcafee 7ce5f04
empty commit
david-mcafee 1f7b01f
revert temp config to run tests in pipeline
david-mcafee 3183f43
subpath update
david-mcafee 5b2bded
add additional package.json
david-mcafee 2e41421
remove top-level package.json
david-mcafee 456f28c
add shim files
david-mcafee File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "name": "aws-amplify/datastore-storage-adapter", | ||
| "main": "../dist/cjs/datastore-storage-adapter/index.js", | ||
| "react-native": "../src/datastore-storage-adapter/index.ts", | ||
| "browser": "../dist/esm/datastore-storage-adapter/index.mjs", | ||
| "module": "../dist/esm/datastore-storage-adapter/index.mjs", | ||
| "typings": "../dist/esm/datastore-storage-adapter/index.d.ts" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused by this,
datastore-storage-adapterisn't a dependency ofaws-amplifyso why are we vending a new export path for it? Is this related to the xml2js change? Will this change how customers need to usedatastore-storage-adapter? Blocking PR just to be safe as this will change the export surface of the library.