Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for specifying a custom endpoint for identity pools: issue 11275 #13025

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

snagatsu
Copy link

Description of changes

you can specify a custom endpoint for accessing a Cognito user pool, such as signIn or signOut. However, you cannot specify a custom endpoint for accessing an identity pool, such as fetchAuthSession. We have added a custom endpoint for the identity pool to the amplifyconfig and implemented a solution.

Issue #, if available

#11275

Description of how you validated changes

You built a custom app using Amplify and verified that you can access the AWS API Gateway URL you provided. AWS API Gateway referenced this URL.
https://aws.amazon.com/jp/blogs/architecture/enriching-amazon-cognito-features-with-an-amazon-api-gateway-proxy/

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@snagatsu snagatsu requested review from a team as code owners February 19, 2024 08:37
@nadetastic
Copy link
Contributor

Hi @snagatsu thank you for your contribution! I'll review this with the team and follow up with any comments/updates.

@adadouche
Copy link

any updates on this PR?

@snagatsu
Copy link
Author

there is no additional information available

@AllanZhengYP
Copy link
Contributor

Hi @snagatsu, thanks a lot for the contribution. It helps a lot when we triage the feature requests. As of the implementation, the proposed one does not quite conform to our abstractions.

The main issue is that we need to resolve the Amplify configuration for endpoint in the provider layer like here and keep the awsClient layer as straightforward as possible:

export class CognitoAWSCredentialsAndIdentityIdProvider

For changes that modifies that public interfaces like this one, we need to go through internal processes to make sure their naming is reasonable and consistent. We also need to update our documentation too.

I will bring this to the team to discuss and keep you updated. The team might pick up the feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants