feat(react-native): add getDeviceName util #13015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinkumar6
force-pushed
the
rn-getDeviceName
branch
from
4cb6f1e
to
5b6c2b7
Compare
jimblanc
requested changes
Feb 15, 2024
3 tasks
HuiSF
reviewed
Apr 23, 2024
| func getDeviceName(resolve: @escaping RCTPromiseResolveBlock, reject _: @escaping RCTPromiseRejectBlock) { | ||
| var deviceName: String | ||
| #if canImport(UIKit) | ||
| deviceName = UIDevice.current.name |
There was a problem hiding this comment.
Use of the name getter of the UIDevice class requires the host app to be assigned with a corresponding entitlement (when running on iOS 16.0+) otherwise it returns the generic string "iPhone", are we going to instruct developers to do so in order to use this API?
There was a problem hiding this comment.
I don't think we should instruct developers to add a corresponding entitlement to use the API since it defaults to a generic device name, example "iPhone"
We could add a callout saying by default
- iOS 15 and earlier: name configured on device "Bob's iPhone X" (iPhone settings>General>About>Name)
- iOS 16 and later: a generic device name "iPhone"/"iPad". Optionally an entitlement is required to get actual device name
cshfang
approved these changes
Apr 29, 2024
jimblanc
approved these changes
Apr 29, 2024
HuiSF
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add custom RN implementation for android and ios to fetch device name. Implementation references taken from
PS: on ios a generic value like 'iPhone' is returned unless a entitlement is added (reference)
Description of how you validated changes
Tested API output on android emulator and ios simulator
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.