Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amazon-cognito-identity-js): sets no-store header for cognito user pools #10804

Merged
merged 3 commits into from Dec 22, 2022

Conversation

haverchuck
Copy link
Contributor

Description of changes

This adds a Cache-Control: 'no-store' header to Client.js in amazon-cognito-identity-js.

Description of how you validated changes

Manually testing.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@haverchuck haverchuck requested a review from a team as a code owner December 21, 2022 21:08
@codecov-commenter
Copy link

Codecov Report

Merging #10804 (fa36dea) into main (7b8cc7b) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #10804      +/-   ##
==========================================
+ Coverage   86.14%   86.15%   +0.01%     
==========================================
  Files         197      197              
  Lines       18379    18379              
  Branches     3911     3911              
==========================================
+ Hits        15833    15835       +2     
+ Misses       2472     2470       -2     
  Partials       74       74              
Impacted Files Coverage Δ
packages/amazon-cognito-identity-js/src/Client.js 50.48% <ø> (ø)
...kages/amazon-cognito-identity-js/src/BigInteger.js 89.71% <0.00%> (+0.40%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants