feature: Add support for immediate flag when using Kinesis analytics providers
#10783
+86
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblanc
commented
Dec 16, 2022
| if (params.event?.immediate) { | ||
| this._sendEvents([params]); | ||
|
|
||
| return Promise.resolve(true); |
There was a problem hiding this comment.
This matches the behavior of this._putToBuffer
AllanZhengYP
approved these changes
Dec 16, 2022
Yep there was a 1 line change required, working on it now. |
Codecov Report
@@ Coverage Diff @@
## main #10783 +/- ##
==========================================
+ Coverage 85.65% 86.15% +0.50%
==========================================
Files 196 197 +1
Lines 18261 18379 +118
Branches 3892 3911 +19
==========================================
+ Hits 15642 15835 +193
+ Misses 2543 2470 -73
+ Partials 76 74 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Jul 20, 2023
Closed
Closed
1 task
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This change adds support for the
immediateflag when usingAWSKinesisProviderorAWSKinesisFirehouseProviderto align with our published API contract. Setting theimmediateflag on a record will trigger the providers to immediately send the record to the appropriate Kinesis client without trying to buffer it. The motivations for this change were to align the API with Pinpoint client & help a customer who was having trouble emitted Kinesis events from a RN application while in the background (due to RN pausing timers, such as the one used to flush the event buffer).Issue #, if available
SIM Issue
Description of how you validated changes
Local testing, clean integration test run. Verified that
immediaterecords were persisted in the Kinesis data stream in a React Native application from both the foreground and background (see attached image).Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.