New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@aws-amplify/datastore): nextjs/swc broken build workaround #10765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added nextjs integ tests; expecting failure in '-basic' * add ds-nextjs-workaround branch to releasable branches to trigger iteggs
jimblanc
previously approved these changes
Dec 12, 2022
jimblanc
approved these changes
Dec 12, 2022
stocaaro
approved these changes
Dec 12, 2022
iartemiev
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
dpilch
approved these changes
Dec 13, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
NextJS 13 enables SWC by default, which sometimes mangles the the build. This PR does two things:
Note: Depends on https://github.com/aws-amplify/amplify-js-samples-staging/pull/494
Issue #, if available
#10732
Description of how you validated changes
Runtime failures were seen as in #10732 with NextJS@13 prod builds. The breakage was isolated by inserting dummy console logs with unique strings to help us determine where we were in the resulting minified build. By doing so, we could see that a variable declaration and later assignment were being eliminated entirely. Setting the var to a default value caused SWC to leave the declaration in and resolved runtime issues.
One of the newly added integ tests (the "basic" one) successfully triggers the error in CI on prod builds without the fix. The fix makes it pass in CI.
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.