New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixed invalid JS
imports
#10716
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Thanks @jimblanc 🎖️
|
Codecov Report
@@ Coverage Diff @@
## main #10716 +/- ##
=======================================
Coverage 85.65% 85.65%
=======================================
Files 196 196
Lines 18261 18261
Branches 3892 3892
=======================================
Hits 15642 15642
Misses 2543 2543
Partials 76 76 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ca44d10
to
28bc9f0
Compare
This pull request fixes 1 alert when merging 0fe1460 into d0dd948 - view on LGTM.com fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Thanks @jimblanc 🎖️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Description of changes
This change fixes invalid
JS
imports in theaws-amplify-react-native
package.Issue #, if available
#10711
Description of how you validated changes
Verified
withAuthenticator
functionality locally.Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.