Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed invalid JS imports #10716

Merged
merged 4 commits into from Nov 28, 2022
Merged

Conversation

jimblanc
Copy link
Contributor

Description of changes

This change fixes invalid JS imports in the aws-amplify-react-native package.

Issue #, if available

#10711

Description of how you validated changes

Verified withAuthenticator functionality locally.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jimblanc jimblanc marked this pull request as ready for review November 28, 2022 16:27
@jimblanc jimblanc requested review from a team as code owners November 28, 2022 16:27
elorzafe
elorzafe previously approved these changes Nov 28, 2022
Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Thanks @jimblanc 🎖️

@hszeto
Copy link

hszeto commented Nov 28, 2022

JS is also being imported in /aws-amplify-react-native/src/Auth/ConfirmSignIn.tsx , but doesn't seems like it's being used. Does it worth cleaning it up in this PR?

@codecov-commenter
Copy link

Codecov Report

Merging #10716 (ca44d10) into main (d0dd948) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #10716   +/-   ##
=======================================
  Coverage   85.65%   85.65%           
=======================================
  Files         196      196           
  Lines       18261    18261           
  Branches     3892     3892           
=======================================
  Hits        15642    15642           
  Misses       2543     2543           
  Partials       76       76           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lgtm-com
Copy link

lgtm-com bot commented Nov 28, 2022

This pull request fixes 1 alert when merging 0fe1460 into d0dd948 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Thanks @jimblanc 🎖️

Copy link
Contributor

@Samaritan1011001 Samaritan1011001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jimblanc jimblanc merged commit 49bdf81 into aws-amplify:main Nov 28, 2022
@jimblanc jimblanc deleted the fix/rn-js-import branch November 28, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants