fix(@aws-amplify/core): Use identityPoolRegion param correctly #10709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #10709 +/- ##
==========================================
+ Coverage 85.71% 86.14% +0.43%
==========================================
Files 196 196
Lines 18335 18337 +2
Branches 3900 3902 +2
==========================================
+ Hits 15715 15797 +82
+ Misses 2544 2465 -79
+ Partials 76 75 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
elorzafe
force-pushed
the
fix/auth-identity-pool-different-region
branch
from
ca6669d
to
75d849f
Compare
helgabalashova
previously approved these changes
Dec 1, 2022
elorzafe
dismissed stale reviews from helgabalashova and jimblanc
via
9c59c2d
jimblanc
previously approved these changes
Dec 2, 2022
| }; | ||
| } | ||
| if (params instanceof GetCredentialsForIdentityCommand) { | ||
| console.log('GetCredentialsForIdentityCommand', params); |
There was a problem hiding this comment.
Do you need that console.log?
| identity_id: '123', | ||
| }); | ||
|
|
||
| console.log('YYYY'); |
There was a problem hiding this comment.
and this one as well?
helgabalashova
approved these changes
Dec 2, 2022
jimblanc
approved these changes
Dec 2, 2022
This was referenced Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
identityPoolRegionparam wasn't use correctly when different regions where used.Issue #, if available
fixes: #6462
Description of how you validated changes
Integ test PR https://github.com/aws-amplify/amplify-js-samples-staging/pull/482
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.