Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(integ): test UMD artifacts #10704

Merged
merged 14 commits into from Nov 29, 2022
Merged

test(integ): test UMD artifacts #10704

merged 14 commits into from Nov 29, 2022

Conversation

AllanZhengYP
Copy link
Contributor

Description of changes

Amplify JS publishes UMD artifacts to CDN distributions. However, these artifacts lack integration tests. This change add spot integration test to auth and geo categories.

Issue #, if available

Associated with: https://github.com/aws-amplify/amplify-js-samples-staging/pull/477

Description of how you validated changes

Integ test run

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AllanZhengYP AllanZhengYP requested review from a team as code owners November 22, 2022 22:41
stocaaro
stocaaro previously approved these changes Nov 23, 2022
Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not block the pipeline for now until we release the UMD artifacts from here.

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #10704 (d8faa08) into main (49bdf81) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #10704   +/-   ##
=======================================
  Coverage   85.65%   85.65%           
=======================================
  Files         196      196           
  Lines       18261    18261           
  Branches     3892     3892           
=======================================
  Hits        15642    15642           
  Misses       2543     2543           
  Partials       76       76           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AllanZhengYP
Copy link
Contributor Author

Confirmed failed new CDN test won't block the release: CircleCI execution example

Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Thanks @AllanZhengYP 🎖️

@AllanZhengYP AllanZhengYP merged commit 92ff2c7 into main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants