Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable per-branch test suite execution in CircleCI #10702

Merged
merged 8 commits into from Nov 23, 2022

Conversation

jimblanc
Copy link
Contributor

@jimblanc jimblanc commented Nov 22, 2022

Description of changes

This change enables us to execute the CircleCI test suite against corresponding branches in the amplify-js-samples-staging repo. Currently this implementation requires an exact match. If no match is found, then CircleCI will default to main.

Why couldn't we just use $? instead of setting a local variable? This was required because if any command in the list exits with a failure status code, CircleCI will fail the test run.

Issue #, if available

Description of how you validated changes

Test runs in CircleCI with and without a matching branch.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jimblanc jimblanc marked this pull request as ready for review November 22, 2022 22:24
@jimblanc jimblanc requested review from a team as code owners November 22, 2022 22:24
Copy link
Contributor

@iartemiev iartemiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@codecov-commenter
Copy link

Codecov Report

Merging #10702 (7a5270e) into main (2320dba) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #10702      +/-   ##
==========================================
+ Coverage   85.64%   85.65%   +0.01%     
==========================================
  Files         196      196              
  Lines       18261    18261              
  Branches     3892     3892              
==========================================
+ Hits        15640    15642       +2     
+ Misses       2545     2543       -2     
  Partials       76       76              
Impacted Files Coverage Δ
...kages/amazon-cognito-identity-js/src/BigInteger.js 89.71% <0.00%> (+0.40%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants