fix: Storage interface types #10696
Merged
fix: Storage interface types #10696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #10696 +/- ##
==========================================
+ Coverage 84.28% 85.65% +1.37%
==========================================
Files 256 196 -60
Lines 18527 18261 -266
Branches 3981 3892 -89
==========================================
+ Hits 15615 15642 +27
+ Misses 2822 2543 -279
+ Partials 90 76 -14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
israx
approved these changes
Nov 21, 2022
| T | ||
| >; | ||
|
|
||
| export type StorageCopyConfig<T extends Record<string, any>> = |
There was a problem hiding this comment.
I see the Record<string, any> type being repeated on most types above. A suggestion I'm thinking would be creating a default config type
type DefaultStorageConfig = Record<string, any>
5 tasks
Closed
1 task
This was referenced Aug 9, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adding Storage generics type clarification.
Without this fix. TS Strict is expressing issues in VSCode and Angular 15 fails to build.
Issue #, if available
#10687
Description of how you validated changes
Running tests and linking this change to an existing project.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.