Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datastore): optional hasOne #10685 #10688

Merged
merged 6 commits into from Nov 18, 2022
Merged

fix(datastore): optional hasOne #10685 #10688

merged 6 commits into from Nov 18, 2022

Conversation

david-mcafee
Copy link
Member

@david-mcafee david-mcafee commented Nov 18, 2022

Description of changes

Issue #, if available

#10685

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@david-mcafee david-mcafee requested a review from a team as a code owner November 18, 2022 19:53
Copy link
Contributor

@iartemiev iartemiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but lets add a test for this please

@svidgen
Copy link
Contributor

svidgen commented Nov 18, 2022

Looks good, but lets add a test for this please

If possible, add to commonAdapterTests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants