fix: predicate logic against bools #10679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svidgen
commented
Nov 16, 2022
svidgen
commented
Nov 16, 2022
Fix type errors
Codecov Report
@@ Coverage Diff @@
## main #10679 +/- ##
==========================================
+ Coverage 85.60% 85.62% +0.01%
==========================================
Files 196 196
Lines 18241 18243 +2
Branches 3887 3887
==========================================
+ Hits 15616 15620 +4
+ Misses 2547 2546 -1
+ Partials 78 77 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dpilch
requested changes
Nov 16, 2022
There was a problem hiding this comment.
Can you add tests for eq and ne on number fields. I found that casting to string also affects numbers. https://github.com/dpilch/predicate-tests
dpilch
previously approved these changes
Nov 16, 2022
iartemiev
previously approved these changes
Nov 16, 2022
stocaaro
reviewed
Nov 16, 2022
dpilch
approved these changes
Nov 16, 2022
stocaaro
approved these changes
Nov 16, 2022
iartemiev
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Predicate filtering logic (used by
observeandobserveQuery) was not working correctly against bools, because we were casting field values to strings before comparison. This appears to be cruft from POC work — I can't otherwise tell why this cast would have been in place.Issue #, if available
Description of how you validated changes
Added tests that were red. Made the change. Tests turned green.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.