Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove VSCode extension #10668

Merged
merged 3 commits into from Nov 15, 2022

Conversation

jimblanc
Copy link
Contributor

Description of changes

This PR removes the old VSCode extension from our repo as it is no longer being actively maintained. The latest version of the plugin has been saved in a branch for future use if needed: https://github.com/aws-amplify/amplify-js/tree/vscode-extension

As a follow up the extension will also be removed from the VSCode marketplace: https://marketplace.visualstudio.com/items?itemName=aws-amplify.aws-amplify-vscode

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jimblanc jimblanc marked this pull request as ready for review November 14, 2022 21:18
@jimblanc jimblanc requested a review from a team as a code owner November 14, 2022 21:18
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2022

Codecov Report

Merging #10668 (327ccc1) into main (8a66823) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #10668   +/-   ##
=======================================
  Coverage   85.59%   85.59%           
=======================================
  Files         196      196           
  Lines       18240    18240           
  Branches     3888     3888           
=======================================
  Hits        15613    15613           
  Misses       2549     2549           
  Partials       78       78           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jimblanc jimblanc changed the title chore: Removed vscode extension chore: Remove vscode extension Nov 14, 2022
@jimblanc jimblanc changed the title chore: Remove vscode extension chore: Remove VSCode extension Nov 14, 2022
Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Thanks @jimblanc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants