docs: V5 breaking change README guidance #10649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblanc
reviewed
Nov 9, 2022
There was a problem hiding this comment.
Looks good! Few random call-outs:
- JS class export has been removed: chore: Remove miscellaneous deprecated exports & prototypes #10528
Amplify.Auth,Amplify.Cache, andAmplify.ServiceWorkerinstances have been removed: chore: MovecachesideEffects to align with other packages #10562- Should we mention the legacy UI packages (v1.x) have all been removed and point customers to the UI docs?
|
From Jim's comment, I caught up with Francisco and made updates. |
Codecov Report
@@ Coverage Diff @@
## main #10649 +/- ##
==========================================
- Coverage 85.59% 85.58% -0.02%
==========================================
Files 196 196
Lines 18240 18240
Branches 3888 3888
==========================================
- Hits 15613 15611 -2
- Misses 2549 2551 +2
Partials 78 78
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AllanZhengYP
reviewed
Nov 9, 2022
abdallahshaban557
previously requested changes
Nov 10, 2022
jimblanc
approved these changes
Nov 11, 2022
AllanZhengYP
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
docs: V5 breaking change README guidance
Look at the commit on my branch to see the markdown rendered.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.