Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add selective-sync-v5 tests to pipeline #10637

Merged
merged 8 commits into from Nov 14, 2022

Conversation

svidgen
Copy link
Contributor

@svidgen svidgen commented Nov 8, 2022

Description of changes

Adds selective sync tests to the pipeline.

To remain in draft until the sample app + tests PR is merged. (merged)

Issue #, if available

Description of how you validated changes

Sample app and cypress tests have been run and pass locally. Manual run on sample app to confirm correct app behavior and behavior over-the-wire.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@svidgen svidgen marked this pull request as ready for review November 10, 2022 15:54
@svidgen svidgen requested review from a team as code owners November 10, 2022 15:54
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2022

Codecov Report

Merging #10637 (33e48eb) into main (92cef8a) will increase coverage by 1.31%.
The diff coverage is 83.87%.

@@            Coverage Diff             @@
##             main   #10637      +/-   ##
==========================================
+ Coverage   84.28%   85.59%   +1.31%     
==========================================
  Files         256      196      -60     
  Lines       18527    18240     -287     
  Branches     3981     3888      -93     
==========================================
- Hits        15615    15613       -2     
+ Misses       2822     2549     -273     
+ Partials       90       78      -12     
Impacted Files Coverage Δ
...ages/amazon-cognito-identity-js/src/CognitoUser.js 79.18% <64.28%> (-0.20%) ⬇️
...on-cognito-identity-js/src/AuthenticationHelper.js 100.00% <100.00%> (ø)
.../amazon-cognito-identity-js/src/CognitoUserPool.js 81.35% <100.00%> (+0.65%) ⬆️
...astore/src/storage/adapter/AsyncStorageDatabase.ts 83.92% <0.00%> (-10.52%) ⬇️
packages/datastore/src/storage/storage.ts 90.24% <0.00%> (-7.41%) ⬇️
packages/analytics/src/Analytics.ts 55.89% <0.00%> (-7.24%) ⬇️
packages/datastore/__tests__/helpers.ts 84.02% <0.00%> (-5.98%) ⬇️
.../datastore/src/storage/adapter/IndexedDBAdapter.ts 84.54% <0.00%> (-3.60%) ⬇️
packages/core/src/JS.ts 90.26% <0.00%> (-1.87%) ⬇️
packages/datastore/__tests__/commonAdapterTests.ts 98.27% <0.00%> (-1.73%) ⬇️
... and 215 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@iartemiev iartemiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants