Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(datastore): add nested predicate integ tests #10619

Merged
merged 4 commits into from Nov 30, 2022
Merged

Conversation

dpilch
Copy link
Contributor

@dpilch dpilch commented Nov 4, 2022

Description of changes

Add nested predicate sample to integ test suite.

Issue #, if available

N/A

Description of how you validated changes

Successful run: https://app.circleci.com/pipelines/github/aws-amplify/amplify-js/16995/workflows/5507d6c4-ce00-4748-95bf-b723a4b49622/jobs/203045

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2022

Codecov Report

Merging #10619 (e3bb923) into main (49bdf81) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #10619   +/-   ##
=======================================
  Coverage   85.65%   85.65%           
=======================================
  Files         196      196           
  Lines       18261    18261           
  Branches     3892     3892           
=======================================
  Hits        15642    15642           
  Misses       2543     2543           
  Partials       76       76           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dpilch dpilch changed the base branch from next-major-version/5 to main November 9, 2022 18:11
@dpilch dpilch marked this pull request as ready for review November 9, 2022 18:11
@dpilch dpilch requested review from a team as code owners November 9, 2022 18:11
@dpilch dpilch requested review from a team as code owners November 17, 2022 16:21
Copy link
Contributor

@iartemiev iartemiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@dpilch dpilch merged commit 2771e0a into main Nov 30, 2022
@dpilch dpilch deleted the nested-predicate-integ branch November 30, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants