fix(pubsub): AppSync in China regions #10087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiscreteTom
requested review from
stocaaro,
elorzafe and
ashika01
as code owners
Codecov Report
@@ Coverage Diff @@
## main #10087 +/- ##
==========================================
- Coverage 86.16% 86.15% -0.02%
==========================================
Files 196 196
Lines 18351 18351
Branches 3905 3905
==========================================
- Hits 15812 15810 -2
- Misses 2464 2466 +2
Partials 75 75
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
siegerts
added
the
first-time-contributor
|
@DiscreteTom thank you for opening this PR. Would you mind adding unit tests for this improvement to this file? |
manueliglesias
force-pushed
the
main
branch
from
5b68474
to
66bfe31
Compare
|
@DiscreteTom - can you please add a test as Ivan mentioned above? |
stocaaro
reviewed
Dec 7, 2022
| @@ -40,6 +40,14 @@ describe('AWSAppSyncRealTimeProvider', () => { | |||
| ); | |||
| expect(result).toBe(false); | |||
| }); | |||
|
|
|||
| test('Non-custom domain in the amazonaws.com.cn subdomain space returns `false`', () => { | |||
There was a problem hiding this comment.
After manually validating the structure of appsync urls in cn, recommending we add a test, which I've gone ahead and committed.
stocaaro
approved these changes
Dec 7, 2022
|
@DiscreteTom Thank you so much for this change. I've done my own validation and added a test and will work with the team to get this merged. |
jimblanc
approved these changes
Dec 7, 2022
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10061
Description of changes
Update
standardDomainPatternto accept endpoints in China regions.Issue #, if available
Fix #10061
Description of how you validated changes
Tested using the updated lib and China region AppSync realtime demo. Passed.
Checklist
yarn testpassesRelevant documentation is changed or added (and PR referenced)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.