New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pubsub): AppSync in China regions #10087
Conversation
Codecov Report
@@ Coverage Diff @@
## main #10087 +/- ##
==========================================
- Coverage 86.16% 86.15% -0.02%
==========================================
Files 196 196
Lines 18351 18351
Branches 3905 3905
==========================================
- Hits 15812 15810 -2
- Misses 2464 2466 +2
Partials 75 75
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@DiscreteTom thank you for opening this PR. Would you mind adding unit tests for this improvement to this file? |
5b68474
to
66bfe31
Compare
@DiscreteTom - can you please add a test as Ivan mentioned above? |
@@ -40,6 +40,14 @@ describe('AWSAppSyncRealTimeProvider', () => { | |||
); | |||
expect(result).toBe(false); | |||
}); | |||
|
|||
test('Non-custom domain in the amazonaws.com.cn subdomain space returns `false`', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After manually validating the structure of appsync urls in cn, recommending we add a test, which I've gone ahead and committed.
@DiscreteTom Thank you so much for this change. I've done my own validation and added a test and will work with the team to get this merged. |
Fix #10061
Description of changes
Update
standardDomainPattern
to accept endpoints in China regions.Issue #, if available
Fix #10061
Description of how you validated changes
Tested using the updated lib and China region AppSync realtime demo. Passed.
Checklist
yarn test
passesRelevant documentation is changed or added (and PR referenced)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.