fix(analytics): correctly extract statusCode from failed request (#5618)

aws-amplify · Apr 29, 2020 · e11e938 · e11e938
1 parent f5db38d
commit e11e938
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/packages/analytics/__tests__/Providers/AWSPinpointProvider-unit-test.ts b/packages/analytics/__tests__/Providers/AWSPinpointProvider-unit-test.ts
@@ -736,7 +736,9 @@ describe('AnalyticsProvider test', () => {
 			test('Exceeded maximum endpoint per user count', async () => {
 				const analytics = new AnalyticsProvider();
 				const mockExceededMaxError = {
-					statusCode: 400,
+					$metadata: {
+						httpStatusCode: 400,
+					},
 					message: 'Exceeded maximum endpoint per user count 10',
 				};
 

diff --git a/packages/analytics/src/Providers/AWSPinpointProvider.ts b/packages/analytics/src/Providers/AWSPinpointProvider.ts
@@ -431,8 +431,9 @@ export class AWSPinpointProvider implements AnalyticsProvider {
 
 	private async _handleEndpointUpdateFailure(failureData: EndpointFailureData) {
 		const { err, endpointObject } = failureData;
-		const { statusCode } = err;
-		logger.debug('updateEndpoint failed', err);
+		const statusCode = err.$metadata && err.$metadata.httpStatusCode;
+
+		logger.error('updateEndpoint failed', err);
 
 		switch (statusCode) {
 			case BAD_REQUEST_CODE:
@@ -482,6 +483,7 @@ export class AWSPinpointProvider implements AnalyticsProvider {
 
 	private _handleEndpointUpdateForbidden(failureData: EndpointFailureData) {
 		const { err, endpointObject } = failureData;
+
 		const { code, retryable } = err;
 
 		if (code !== EXPIRED_TOKEN_CODE && !retryable) {

diff --git a/packages/analytics/src/Providers/EventBuffer.ts b/packages/analytics/src/Providers/EventBuffer.ts
@@ -150,8 +150,8 @@ export default class EventsBuffer {
 	}
 
 	private _handlePutEventsFailure(err, eventMap: EventMap) {
-		logger.debug('_putEvents Failed:', err);
-		const { statusCode } = err;
+		logger.error('_putEvents Failed: ', err);
+		const statusCode = err.$metadata && err.$metadata.httpStatusCode;
 
 		if (RETRYABLE_CODES.includes(statusCode)) {
 			const retryableEvents = Object.values(eventMap);