chore(datastore): add query & mutate impl #4858
Conversation
Equartey
force-pushed
the
chore/flutter-api-query-mutate
branch
from
73d2d08
to
ea0871d
Compare
| @@ -35,7 +35,7 @@ class HubEventElementWithMetadata<M extends Model> extends HubEventElement<M> { | |||
| final int version; | |||
|
|
|||
| /// The last time the model was updated locally, in seconds since epoch. | |||
| final int lastChangedAt; | |||
| final int? lastChangedAt; | |||
There was a problem hiding this comment.
This is part of the public API so it is technically a breaking change. Was this intended to be part of the public API? Is this a class that customers use (is there a use case in which they might use it)?
Ideally we should try to find a way to make this non-breaking. If that is not feasible and this was never intended to be public was can discuss deprecating this or marking it as internal.
| @@ -63,7 +63,7 @@ class DataStoreHubEventStreamHandlerTests: XCTestCase { | |||
| waitForExpectations(timeout: 1.0) | |||
| // cancellation needed to make sure that Hub token is invalidated to | |||
| // prevent collisions between tests | |||
| hubHandler.onCancel(withArguments: nil) | |||
| let _ = hubHandler.onCancel(withArguments: nil) | |||
There was a problem hiding this comment.
Q: what is the purpose of this change? Is this the norm in swift or enforced via linting?
There was a problem hiding this comment.
Swift linter complains about the value was not bing used. This is a common pattern to satisfy the linter rule, while denoting the return value is not used. Relevant SO
| pod 'Amplify', path: '../../ios/internal/' | ||
| pod 'AWSPluginsCore', path: '../../ios/internal/' | ||
| pod 'AWSDataStorePlugin', path: '../../ios/internal/' | ||
| pod 'Amplify', path: '../../ios/internal/', :inhibit_warnings => true |
There was a problem hiding this comment.
Q: What is the purpose of this change?
There was a problem hiding this comment.
CI logs were showing tons of lint warnings for these files, but since we they are from Amplify Swift we don't care. We're not going to modify these files. Adding this line prevents warning messages in CI, making those logs more readable.
| @@ -63,7 +63,7 @@ class DataStoreHubEventStreamHandlerTests: XCTestCase { | |||
| waitForExpectations(timeout: 1.0) | |||
There was a problem hiding this comment.
Not related to this PR, but we should remove these from generated files in .gitattributes. Everything under **/example/ios/** is treated as generated code since the majority of it is generated by flutter during flutter create. We should remove unit_tests from this.
Could you make that change in this feature branch (can be in a follow up PR) since there will probably be quite a few PRs that will updates native tests?
There was a problem hiding this comment.
Good call out, I added that to this branch.
packages/amplify_datastore/lib/src/utils/native_api_helpers.dart
Outdated
Show resolved
Hide resolved
| @@ -63,7 +63,7 @@ class DataStoreHubEventStreamHandlerTests: XCTestCase { | |||
| waitForExpectations(timeout: 1.0) | |||
Equartey
force-pushed
the
chore/flutter-api-query-mutate
branch
from
64689fd
to
c1b3b7a
Compare
Equartey
merged commit ab777f2
into
feat/datastore-spm-migration
Description of changes:
Adds Swift FlutterApiPlugin query and mutate implementations.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.