fix: wait for in progress requests to cancel before completing .pause() and .cancel()
#4844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jordan-Nelson
force-pushed
the
chore/storage-e2e-flutter-beta
branch
2 times, most recently
from
d3a9dde
to
16fe12b
Compare
Jordan-Nelson
changed the title
.pause() and .cancel()
Jordan-Nelson
changed the title
.pause() and .cancel().pause() and .cancel()
Jordan-Nelson
force-pushed
the
chore/storage-e2e-flutter-beta
branch
3 times, most recently
from
ee4fc5b
to
a8d4f83
Compare
Jordan-Nelson
force-pushed
the
chore/storage-e2e-flutter-beta
branch
from
a8d4f83
to
cf93cde
Compare
Comment on lines
+357
to
+359
| testWidgets('can cancel (file size: $fileSize mb)', (_) async { | ||
| final fileId = uuid(); | ||
| final path = 'public/upload-file-cancel-$fileId'; |
There was a problem hiding this comment.
should this also be checking if the file size is 5mb like pause test since small file uploads can't be canceled??
There was a problem hiding this comment.
Cancel is supported for both single part and multi part uploads. Only resume/pause are not supported for single part uploads
Equartey
approved these changes
May 13, 2024
khatruong2009
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
.pause()and.cancel()..cancel()tests for download. These are failing on flutter beta and it is not immediately obvious why. Further investigation is required.The main change in this PR is to wait to complete the
.pause()and.cancel()futures until in flight requests have been cancelled. There are a few motivations for this:.pause()and.cancel()return are resulting in errors being thrown after tests complete. As of Flutter 3.22 these will result in test failures..pause()and.cancel()return futures, it is reasonable to expect that the operation is fully paused/cancelled when the future completes, but this isn't currently the case as there are network requests that are cancelled after the future returns.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.