feat: pass form save result to onSuccess handler #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwoolum
reviewed
Jan 29, 2024
| @@ -70,7 +70,7 @@ exports[`form-render utils should generate before & complete types if datastore | |||
| "{ | |||
| clearOnSuccess?: boolean; | |||
| onSubmit?: (fields: mySampleFormInputValues) => mySampleFormInputValues; | |||
| onSuccess?: (fields: mySampleFormInputValues) => void; | |||
| onSuccess?: (result: any) => void; | |||
There was a problem hiding this comment.
Not in love with the any. Don't we know the full shape of the object including Ids?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fields object is passed into onSuccess handler in forms. The result of save call would be more helpful
Solution
pass save result to onSuccess handler
Manual tests
Manual save local
Automated tests
Housekeeping
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.