Fix e2e tests for pluralization #7590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would prefer to land #7584 first so that the unrelated typo fix is not at risk of being reverted again. |
Currently, we’re testing the iterative update by renaming the intial Todo model and updating it to Todos. Previously, this created a resolver called listTodoss (because it incorrectly blindly appended s). With the pluralization fix, it creates a resolver called listTodos - which unfortunately already exists and therefore appsync throws a Only one resolver is allowed per field error (see appsync bug) ref: appsync bug: aws/aws-appsync-community#128 initial todo model: https://github.com/aws-amplify/amplify-cli/blob/master/packages/amplify-e2e-tests/schemas/iterative-push/change-model-name/initial-schema.graphql#L6 final todo model: https://github.com/aws-amplify/amplify-cli/blob/master/packages/amplify-e2e-tests/schemas/iterative-push/change-model-name/final-schema.graphql#L6
edwardfoyle
approved these changes
Jun 23, 2021
cjihrig
pushed a commit
to ctjlewis/amplify-cli
that referenced
this pull request
Jul 12, 2021
Currently, we’re testing the iterative update by renaming the intial Todo model and updating it to Todos. Previously, this created a resolver called listTodoss (because it incorrectly blindly appended s). With the pluralization fix, it creates a resolver called listTodos - which unfortunately already exists and therefore appsync throws a Only one resolver is allowed per field error (aws/aws-appsync-community#128)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
When #7258 was merged, e2e tests began failing because of the new
improvePluralizationfeature flag behavior during certain test runs.We test the iterative update feature by renaming the intitial Todo model and updating it to Todos. Previously (before #7258), this created a resolver called
listTodoss(because it incorrectly blindly appendeds). With the pluralization fix, it creates a resolver called listTodos - which unfortunately already exists and therefore appsync throws a Only one resolver is allowed per field error (see appsync bug).This PR fixes the broken e2e tests by renaming the model from
TodotoTaskinstead of toTodos, therefore eliminating the conflict.Issue #, if available
#4224
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.