fix(cli): moving the spinner above category initialization tasks #4836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhockett
approved these changes
Jul 15, 2020
|
This pull request introduces 1 alert when merging 6959132d558f3029c86268b82dc25018bd62e24c into 79c774a - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #4836 +/- ##
==========================================
+ Coverage 60.52% 61.25% +0.73%
==========================================
Files 350 349 -1
Lines 15203 15021 -182
Branches 2880 2858 -22
==========================================
Hits 9201 9201
+ Misses 5514 5332 -182
Partials 488 488
Continue to review full report at Codecov.
|
jhockett
suggested changes
Jul 15, 2020
stopping the spinner before running category init tasks since the spinner can swallow outputs (such as questions via inquirer) re aws-amplify#4795
jhockett
approved these changes
Jul 15, 2020
nikhname
pushed a commit
to nikhname/amplify-cli
that referenced
this pull request
Jul 27, 2020
…-amplify#4836) * fix(cli): moving the spinner above category initialization tasks stopping the spinner before running category init tasks since the spinner can swallow outputs (such as questions via inquirer) re aws-amplify#4795
sebastiancrossa
pushed a commit
to MLH-Fellowship/amplify-cli
that referenced
this pull request
Aug 4, 2020
…-amplify#4836) * fix(cli): moving the spinner above category initialization tasks stopping the spinner before running category init tasks since the spinner can swallow outputs (such as questions via inquirer) re aws-amplify#4795
sebastiancrossa
pushed a commit
to MLH-Fellowship/amplify-cli
that referenced
this pull request
Aug 25, 2020
…-amplify#4836) * fix(cli): moving the spinner above category initialization tasks stopping the spinner before running category init tasks since the spinner can swallow outputs (such as questions via inquirer) re aws-amplify#4795
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stopping the spinner before running category init tasks since the spinner can swallow outputs (such
as questions via inquirer)
related issue: sindresorhus/ora#90
re #4795
change type to intersection type in e2e
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.