Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import auth export #12723

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix: import auth export #12723

wants to merge 2 commits into from

Conversation

joekiller
Copy link
Contributor

@joekiller joekiller commented Jun 2, 2023

Description of changes

fix: import auth export

  • keep overrides generated by push-resources/formNestedStack
  • remove unused AuthModeLastUpdated from export

fix: 'parameters' of undefined error when exporting with imported resources

Issue #, if available

#9772

Description of how you validated changes

I have tested deploying against a very complex and auth exported stack internally and then also developed a proof of concept stack here: https://github.com/joekiller/amplify-scratch

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@joekiller joekiller requested a review from a team as a code owner June 2, 2023 06:12
- keep overrides generated by push-resources/formNestedStack
- remove unused AuthModeLastUpdated from export
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant