Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve validation for api expiry input #902

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve validation for api expiry input #902

wants to merge 1 commit into from

Conversation

basilzuberi
Copy link

Description of changes

  • Fix the logic behind throwing an error message when setting API key expiry to 1 day and 0 days.

Issue #, if available

#895

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@basilzuberi basilzuberi requested a review from a team as a code owner October 19, 2022 06:15
@josefaidt
Copy link
Contributor

Hey @basilzuberi 👋 thank you for taking the time to file this!

@basilzuberi
Copy link
Author

Hey @basilzuberi 👋 thank you for taking the time to file this!

No problem! Let me know if any improvements can be made :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianyoung damianyoung damianyoung approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@basilzuberi @josefaidt @damianyoung